Crash with SZ_GetSpace overflow on (Nick)

[raulitop]

Recently I added some new features to my server.

I don't know where is the problem, but every 2 days server is crashing with console overflowed with this message: SZ_GetSpace overflow on (Nick)
All the time on the same client, 3512 lines of messages.

Yes, it's an overflow on the client.
But client isn't dropped and result an overflow on the server (crash).

ReHLDS should add a protection.
The client may be kicked when 'X' amount of prints done, that's to prevent server crash.

How to kick client? Is it only possible inside ReHLDS?
That's where protection must be applied: https://github.com/dreamstalker/rehlds/blob/master/rehlds/engine/common.cpp#L1241

5 Авг 2021

Maybe change?

 Con_Printf("%s: overflow on %s\n", __func__, buffername);

to

 Con_NetPrintf("%s: overflow on %s\n", __func__, buffername);

Like in this commit: https://github.com/dreamstalker/rehlds/commit/98db4672cf90f82052888ae5a5c0fb71a7298dce

 

[raulitop]

It seems to be caused by so many Hud/DHUD displaying at the same time or too often.

I tried to reduce the calls and it seems to work.

Anyways, should be a protection against server crash