Question about get_players - for(new....)

[PurposeLess]

Hello,
I learned lots of methods to get players.
And I wanted to ask you which one should I use.
Many people told me all these codes are same, i should use whatever I want.
Which one should I use?

(I always use get_players)

func()
{
    // g_MaxPlayers = get_member_game(m_nMaxPlayers);     in plugin_init
    // g_connected  [true] on putinserver [false] on disconnected

    // for(new id = 1; id <= MAX_CLIENTS; id++)
    // for(new id = 1; id <= get_member_game(m_nMaxPlayers); id++)
    for(new id = 1; id <= g_MaxPlayers; id++)
    {
        if(get_member(id, m_iTeam) == TEAM_TERRORIST && g_connected[id])
        {
            client_print_color(id, id, "You are a terrorist");
        }
    }
}

func_get_players()
{
    new players[MAX_CLIENTS], inum;
    // maybe it should be new, idk
    static id;
    get_players(players, inum, "e", "TERRORIST");
    for(new i; i<inum; i++)
    {
        id = players[i];
        client_print_color(id, id, "You are a terrorist");
    }
}

 

[twisterniq]

for(new i = 1; i <= MaxClients; i++)
{
    if(is_user_connected(i) && !is_user_bot(i) && get_member(i, m_iTeam) == TEAM_TERRORIST)
        client_print_color(i, print_team_red, "^1You are a ^3terrorist");
}

new iPlayers[MAX_PLAYERS], iPlayerCount;
get_players_ex(iPlayers, iPlayerCount, GetPlayers_ExcludeBots|GetPlayers_MatchTeam, "TERRORIST");

for(new i; i < iPlayerCount; i++)
{
    client_print_color(iPlayers[i], print_team_red, "^1You are a ^3terrorist");
}

The difference is that in the first case there is only once for loop, while in the second case there are two (the first one is done in get_players). Theoretically, the second should be faster because the first for loop is done in C++ and not pawn, but there are two for loops so the first one, IIRC, is faster, but there will be MaxClients iterarions (MaxClients equals to the number of slots of server), while in the second case there will be as much iterations as players were found.

 

[PurposeLess]

but there are two for loops so the first one, IIRC, is faster, but there will be MaxClients iterarions (MaxClients equals to the number of slots of server), while in the second case there will be as much iterations as players were found.

So, you recommend me to use first one?
Isn't a problem that checking if(is_user_connected(i) && !is_user_bot(i) && get_member(i, m_iTeam) == TEAM_TERRORIST)
as far as number of players?

for(new i = 1; i <= MaxClients; i++)
{
    if(is_user_connected(i) && !is_user_bot(i) && get_member(i, m_iTeam) == TEAM_TERRORIST)
        client_print_color(i, print_team_red, "^1You are a ^3terrorist");
}

 

[jocasrb]

Спойлер: Offtopic

w0w any difference between get_players and _ex ?

 

[Nordic Warrior]

jocasrb, makes it possible to use more understandable flags.

 

[jocasrb]

Oh i though i will be missing something more than syntax, spasibo!

 

[twisterniq]

So, you recommend me to use first one?

I think you can use what you prefer. I use in my plugins get_players_ex just because I'm used to use it.

24 Авг 2019

@w0w any difference between get_players and _ex ?

get_players_ex is a stock in which is called read_flags and then get_players.