Custom grenades

[drag1c]

Does anyone have an idea how to change this code to not throw errors if custom grenade exists (healthnade, decoy, molotov...):

public get_grenade_race(grenade)
{
    switch (cs_get_weapon_id(grenade))
    {
        case CSW_HEGRENADE:     return _:GRENADE_EXPLOSIVE
        case CSW_FLASHBANG:     return _:GRENADE_FLASHBANG
        case CSW_SMOKEGRENADE:     return _:GRENADE_SMOKEGREN
    }
    
    return -1

}

 

[drag1c]

public get_grenade_race(grenade)
{
    switch (cs_get_weapon_id(grenade))
    {
        case CSW_HEGRENADE:     return _:GRENADE_EXPLOSIVE
        case CSW_FLASHBANG:     return _:GRENADE_FLASHBANG
        case CSW_SMOKEGRENADE:     return _:GRENADE_SMOKEGREN
        case CSW_GLOCK:         return _:GRENADE_SMOKEGREN
        case CSW_G3SG1:         return _:GRENADE_SMOKEGREN
    }

    return -1

}

edit: Not working. Error popped-up again after 2 rounds.

 

[BalbuR]

man
did u know thats u should show us error maybe?

6 Фев 2023

ofc u should validate u'r entity before check for example

for checking custom grenade u can check it by custom classname like a molotov: FClassnameIs(grenade, "weapon_molotov")

https://dev-cs.ru/amxx/reapi/FClassnameIs/view

 

[drag1c]

L 02/06/2023 - 06:51:54: [AMXX] Displaying debug trace (plugin "nademodes.amxx", version "11.2")
L 02/06/2023 - 06:51:54: [AMXX] Run time error 4: index out of bounds
L 02/06/2023 - 06:51:54: [AMXX]    [0] nademodes.sma::get_grenade_race (line 4233)
L 02/06/2023 - 06:51:54: [AMXX]    [1] nademodes.sma::fw_track_explosion (line 2241)

My apologies. I asually share error

 

[BalbuR]

public get_grenade_race(grenade)
{
    switch (cs_get_weapon_id(grenade))
    {
        case CSW_HEGRENADE:     {
            if (FClassnameIs(grenade, "weapon_molotov")) {
                return -1;
            }
            return _:GRENADE_EXPLOSIVE
        }
        case CSW_FLASHBANG:     return _:GRENADE_FLASHBANG
        case CSW_SMOKEGRENADE:  return _:GRENADE_SMOKEGREN
    }
    
    return -1
}

smth like this

 

[BlackSignature]

https://github.com/alliedmodders/amxmodx/blob/9fbf91ded017111f35338dff502882d7049ce1f6/modules/cstrike/cstrike/CstrikeNatives.cpp#L160

Это нормально что cs_get_weapon_id() в приложенном nademodes.sma отрабатывает в отношении класснейма "grenade" ?
564 строчка

RegisterHam(Ham_Think, "grenade", "fw_track_explosion")

Строчка 2200

if (get_grenade_race(grenade) == -1)

Я читаю код оригинала и там этого нет.

 

[drag1c]

https://github.com/alliedmodders/amxmodx/blob/9fbf91ded017111f35338dff502882d7049ce1f6/modules/cstrike/cstrike/CstrikeNatives.cpp#L160

Is it normal that cs_get_weapon_id() in the attached nademodes.sma works for the classname "grenade" ?
564 line

RegisterHam(Ham_Think, "grenade", "fw_track_explosion")

Line 2200

if (get_grenade_race(grenade) == -1)

I read the original code and it's not there.

It might be I've tried to change some things because I remember I typed something like

if (get_grenade_race(grenade) == -1)

I've tried lot of different things and nothing successful.

I will try option from Balbur and notify if ok. BalbuR this is from reapi library?

Also, is this a valid statement (can I use 'or' with this function)?

if (FClassnameIs(grenade, "weapon_molotov") || FClassnameIs(grenade, "weapon_healthnade") || FClassnameIs(grenade, "weapon_decoy")) {
                return -1;
            }

 

[drag1c]

I've used

public get_grenade_race(grenade)
{
    switch (cs_get_weapon_id(grenade))
    {
        case CSW_HEGRENADE:     {
          
            if (FClassnameIs(grenade, "weapon_molotov") || FClassnameIs(grenade, "weapon_healthnade") || FClassnameIs(grenade, "weapon_decoy")) {
                return -1;
            }

            return _:GRENADE_EXPLOSIVE
        }
        case CSW_FLASHBANG:     return _:GRENADE_FLASHBANG
        case CSW_SMOKEGRENADE:  return _:GRENADE_SMOKEGREN
    }
  
    return -1
}

but I still have an error:

L 02/07/2023 - 05:58:51: [AMXX] Displaying debug trace (plugin "nademodes.amxx", version "11.2")
L 02/07/2023 - 05:58:51: [AMXX] Run time error 4: index out of bounds
L 02/07/2023 - 05:58:51: [AMXX]    [0] nademodes.sma::get_grenade_race (line 4232)
L 02/07/2023 - 05:58:51: [AMXX]    [1] nademodes.sma::fw_track_explosion (line 2236)

Here attached is full code Im using. Plugin works fine, it just write a lot of logs which is not good.
Changes made in file:
rows:
194

const ACCESS = ADMIN_LEVEL_H;

276

#define grenade_can_be_used(%1,%2) ((get_option(OPTION_NADES_IN_EFFECT) & NADE_BIT[%1]) && (get_user_flags(%2) & ACCESS)) ? 1 : 0

4224-4239

above in email

 

[Nordic Warrior]

drag1c, под каждую кастомную гранату нужно своё решение подбирать. Прикрепи плагин Молотова

 

[drag1c]

Yeah,
I assume healthnade goes under csw_smokegrenade and for decoy I have to speak with plugin owner since I dont have code.
concerning this reapi_molotov, it also should go under csw_smokegrenade by the code...

Here attached is molotov sma.

 

[drag1c]

Here below is solution for all three types of bombs:

public get_grenade_race(grenade)
{
    switch (cs_get_weapon_id(grenade))
    {
        case CSW_HEGRENADE:     {
            if (FClassnameIs(grenade, "weapon_molotov") || get_entvar(grenade, var_impulse) == 1337) {
                return -1;
            }
            return _:GRENADE_EXPLOSIVE
        }
        case CSW_FLASHBANG:     return _:GRENADE_FLASHBANG
        case CSW_SMOKEGRENADE:     {
            if (FClassnameIs(grenade, "weapon_healthnade")) {
                return -1;
            }   
            return _:GRENADE_SMOKEGREN
        }
    }
    return -1
}

The topic could be locked.