Access Manager issue - flags not removed after expiring

drag1c · 17 Янв 2023

Plugin does not remove flags when expired.

This is example.
Server time (current check):
2023/01/17 - 21:07:36.

Note: Im using and pruning option.

Flag x is supervip on our server.

BlackSignature · 18 Янв 2023

drag1c, it prune expired rows once per day

drag1c · 18 Янв 2023

BlackSignature написал(а):
drag1c, it prune expired rows once per day

Thank you for this information. I did not know... (I will check what's happening)
What about expiring admins? If time is out, does flags dissappear immediately or after first amx_reloadadmins ?

Edit: Checked

Expired: 1/14/2023, 11:00:19 PM
Line is still there, user still has "x" flag.

This is amx_amxadmins structure

BlackSignature · 18 Янв 2023

drag1c, after amx_reloadadmins

18 Янв 2023

drag1c show me row with column names. i don't remember where is what column

18 Янв 2023

drag1c 'days' is 0 so row skipped by prune condition

Код:

SELECT `id` FROM `amx_amxadmins` WHERE `ingame` = 1 AND `days` != 0 AND `expired` <= UNIX_TIMESTAMP(NOW())

i don't remember what reason is to use 'days' column. may be condition can be replaced with

Код:

SELECT `id` FROM `amx_amxadmins` WHERE `ingame` = 1 AND `expired` <= UNIX_TIMESTAMP(NOW())

drag1c · 18 Янв 2023

Here below is database picture:

Скрытое содержимое могут видеть только пользователь группы: Web Dev, Администратор, Модератор, Скриптер

Yeah, I find days not much important too. I should remove check for days !=0

drag1c · 18 Янв 2023

Could you check concerning amx_reloadadmins, does it pull request for column expired ?

BlackSignature · 18 Янв 2023

drag1c, what i need to check? Don't understand you.

drag1c · 18 Янв 2023

To check when amx_reloadadmins is typed, does it read expired column from the database.

drag1c · 19 Янв 2023

From my perspective, this part is critical.
It checks days = 0 or expired > unix_timestamp(now())
So, again it checks for days.
Maybe last row should be something like:

Код:

AND (`a`.`expired` = 0 OR `a`.`expired` > UNIX_TIMESTEAMP(NOW()))

If you give admin to someone like: amx_addadmin "steamid" "flags" "time", if you set "time" to "0", expired will be "0".
Example:

Please, tell me what do you think.

mIDnight · 19 Янв 2023

It's not working like that look at source code where admin is expired, 0 = admin with no expiry and expired should be 1, that is how it does work.

drag1c · 19 Янв 2023

I just tested this way from my comment above and it seems it works.
I gave flag "x" to user on 5 mins. I was following him whole time. After 5 mins I wrote amx_reloadadmins and his flag got removed.
I've repeated process for 3 times and all 3 times were successful (2nd times were per 1 min, to not wait)

So, if anyone willing to give flag to someone which lasts less than 1 day:
1) Prune should not look at days
2) func_loadAdminsSql should not look at days
The only important thing is expired column, which is written in timestamp string.

This is from my perspective, after 3 testings. All other admins and flags stayed.
Tomorrow I will see what will happen with these expired flags and will they be pruned.

drag1c · 19 Янв 2023

Код:

"SELECT `id` FROM `amx_amxadmins` WHERE `ingame` = 1 AND `expired` > '0' AND `expired` <= UNIX_TIMESTAMP(NOW())"

is this a valid line?

BlackSignature · 19 Янв 2023

drag1c, i think 'days' usage is just a legacy behavior based on other systems that works with csbans. i don't know what you want to do, feel free to change conditions according to your needs. When plugin was writen, i take in mind how csbans write/modify rows when you add/change account data via web-part. I agree that this schema does not fit to usage like 'flags for 5 minutes'.

In AccessManager.sma you can use dirty hack to bypass this issue. Just change

Код:

iDays = (iMinutes * SECONDS_IN_MINUTE) / SECONDS_IN_DAY

to

Код:

iDays = max(1, (iMinutes * SECONDS_IN_MINUTE) / SECONDS_IN_DAY))

So every insertion via native will use 1 as 'days' minimal value and rows will be removed even with default conditions (as it was in original code).
I think bad things may happen if you modify that rows via csbans later (days can be reset to 0 due changing data), but that is the other question

19 Янв 2023

Another way is to use 'expired' instead of 'days' in prune / load conditions (in AccessMagager.sma). Global condition to use this schema (i just don't remember how csbans works) -'expired' must be 0 when account is permanent, and have any other value if account is non-permanent. If csbans will not mess with this, method will work.

To use 'expired' instead of 'days' just change

Код:

AND (`a`.`days` = '0' OR `a`.`expired` > UNIX_TIMESTAMP(NOW()))

to

Код:

AND (`a`.`expired` = '0' OR `a`.`expired` > UNIX_TIMESTAMP(NOW()))

and

Код:

"SELECT `id` FROM `amx_amxadmins` WHERE `ingame` = 1 AND `days` != 0 AND `expired` <= UNIX_TIMESTAMP(NOW())"

to

Код:

"SELECT `id` FROM `amx_amxadmins` WHERE `ingame` = 1 AND `expired` != 0 AND `expired` <= UNIX_TIMESTAMP(NOW())"

drag1c · 19 Янв 2023

I'm not using CS-Bans, so this will be perfect !
For the last row, I wrote

Код:

And `expired` > 0

, but I think your method with != 0 seems more valid.

Thank you sir!

drag1c · 19 Янв 2023

Please lock this topic. Topic is solved

Access Manager issue - flags not removed after expiring

drag1c

Download all Attachments

BlackSignature

drag1c

Download all Attachments

BlackSignature

drag1c

drag1c

BlackSignature

drag1c

drag1c

mIDnight

drag1c

drag1c

BlackSignature

drag1c

drag1c

Пользователи, просматривающие эту тему